Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactoring of direct solution code #317

Merged
merged 3 commits into from
Dec 24, 2024
Merged

Minor refactoring of direct solution code #317

merged 3 commits into from
Dec 24, 2024

Conversation

atztogo
Copy link
Collaborator

@atztogo atztogo commented Dec 24, 2024

No description provided.

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 6 lines in your changes missing coverage. Please review.

Project coverage is 67.54%. Comparing base (cf0ab00) to head (47aaab5).
Report is 43 commits behind head on develop.

Files with missing lines Patch % Lines
phono3py/conductivity/direct_solution.py 75.00% 5 Missing ⚠️
phono3py/conductivity/utils.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #317      +/-   ##
===========================================
+ Coverage    66.65%   67.54%   +0.89%     
===========================================
  Files           73       71       -2     
  Lines        12901    12720     -181     
===========================================
- Hits          8599     8592       -7     
+ Misses        4302     4128     -174     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atztogo atztogo merged commit 5604d36 into develop Dec 24, 2024
14 checks passed
@atztogo atztogo deleted the for-win branch December 24, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant